Fix Magiclysm json errors #34525
Merged
Fix Magiclysm json errors #34525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bunch of errors in Magiclysm json brought to light by my new json sanity checking.
jbytheway
force-pushed
the
fix_magiclysm_json
branch
from
1a40f82 to
4363b8a
Compare
|
a note about the electrical damage, it'll be possible eventually as my enchantment project progresses. |
|
Yeah, that's on me, I was a lot more novice at the time and didn't know that wouldn't work. |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix assorted minor Magiclysm json errors"
Purpose of change
To fix json errors brought to light by the stricter json error checking I have locally (not yet PRed).
Describe the solution
The same as #34455, except for Magiclysm rather than the core game.
Describe alternatives you've considered
One of the things being attempted here which doesn't work is to give a melee weapon electrical damage. It looks like melee weapon damage ought to by lifted into a
damage_instance, to match ranged damage and monster damage.Additional context
I tackled this mod first because it's tested in CI.